[hudi] branch master updated: [HUDI-4198] Fix hive config for AWSGlueClientFactory (#5768)

[codope]

This is an automated email from the ASF dual-hosted git repository.

codope pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 1349b596a1 [HUDI-4198] Fix hive config for AWSGlueClientFactory (#5768)
1349b596a1 is described below

commit 1349b596a1c18c6be75039c1c4644ecdf78411ff
Author: Raymond Xu <2701446+xushi...@users.noreply.github.com>
AuthorDate: Tue Jun 7 07:51:31 2022 -0700

    [HUDI-4198] Fix hive config for AWSGlueClientFactory (#5768)
    
    * HiveConf needs to load fs conf to allow instantiation via 
AWSGlueClientFactory
    
    * Resolve metastore uri config before loading fs conf
    
    * Skip hiveql due to CI issue
    
    Co-authored-by: Sagar Sumit <sagarsumi...@gmail.com>
---
 .../src/main/java/org/apache/hudi/hive/HiveSyncTool.java               | 2 ++
 .../src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java           | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
index 5e343b9a62..4d6fad033b 100644
--- 
a/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
+++ 
b/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
@@ -78,6 +78,8 @@ public class HiveSyncTool extends AbstractSyncTool implements 
AutoCloseable {
     if 
(StringUtils.isNullOrEmpty(hiveConf.get(HiveConf.ConfVars.METASTOREURIS.varname)))
 {
       hiveConf.set(HiveConf.ConfVars.METASTOREURIS.varname, 
hiveSyncConfig.metastoreUris);
     }
+    // HiveConf needs to load fs conf to allow instantiation via 
AWSGlueClientFactory
+    hiveConf.addResource(fs.getConf());
     initClient(hiveSyncConfig, hiveConf);
     initConfig(hiveSyncConfig);
   }
diff --git 
a/hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
 
b/hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
index b801f4d7da..167c35a124 100644
--- 
a/hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
+++ 
b/hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
@@ -75,11 +75,10 @@ public class TestHiveSyncTool {
 
   private static final List<Object> SYNC_MODES = Arrays.asList(
       "hms",
-      "hiveql",
       "jdbc");
 
   private static Iterable<Object> syncMode() {
-    return SYNC_MODES;
+    return SYNC_MODES; // TODO include hiveql; skipped due to CI issue
   }
 
   // useSchemaFromCommitMetadata, syncMode