xushiyan commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r854918528
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -774,4 +785,23 @@ object DataSourceOptionsHelper {
override def apply (input: From): To = function (input)
}
}
+
+ implicit def convert[T, U](prop: ConfigProperty[T])(implicit converter: T =>
U): ConfigProperty[U] = {
+ checkState(prop.hasDefaultValue)
Review Comment:
this could implicitly break when add a new config with no default. i see
this improves code quality but we should avoid nice-to-have changes in the last
min patch before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
