danny0405 commented on PR #5087: URL: https://github.com/apache/hudi/pull/5087#issuecomment-1100510039
> @danny0405 : can you follow up on the patch when you get a chance. guess author is waiting for review follow up from you. a gentle reminder. I don't see there is any gains for current stage of code, besides the duplicate code reduction, and with this patch, this is regression for performance for unnecessary copy of objects. So i'm not very sure we should work in this direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
