danny0405 commented on code in PR #5252:
URL: https://github.com/apache/hudi/pull/5252#discussion_r845828970


##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -589,6 +591,7 @@ public void 
testBasicAppendAndScanMultipleFiles(ExternalSpillableMap.DiskMapType
         .withSpillableMapBasePath(BASE_OUTPUT_PATH)
         .withDiskMapType(diskMapType)
         .withBitCaskDiskMapCompressionEnabled(isCompressionEnabled)
+        .withPartition(getRelativePartitionPath(new Path(basePath), new 
Path(logFilePaths.get(0)).getParent()))
         .build();

Review Comment:
   Can we inline the fix into the HoodieMergedLogRecordScanner so that there is 
no need to change these classes ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to