nsivabalan commented on a change in pull request #5155:
URL: https://github.com/apache/hudi/pull/5155#discussion_r838804405
##########
File path: packaging/hudi-utilities-bundle/pom.xml
##########
@@ -103,6 +103,7 @@
<include>org.apache.hudi:hudi-hadoop-mr</include>
<include>org.apache.hudi:hudi-timeline-service</include>
<include>org.apache.hudi:hudi-aws</include>
+ <include>org.apache.hudi:hudi-datahub-sync</include>
Review comment:
may I know why do we need this ?
##########
File path:
hudi-sync/hudi-datahub-sync/src/main/java/org/apache/hudi/sync/datahub/DataHubSyncClient.java
##########
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.sync.datahub;
+
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.TableSchemaResolver;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.sync.common.AbstractSyncHoodieClient;
+import org.apache.hudi.sync.common.HoodieSyncException;
+import org.apache.hudi.sync.datahub.config.DataHubSyncConfig;
+
+import com.linkedin.common.urn.DatasetUrn;
+import com.linkedin.data.template.SetMode;
+import com.linkedin.data.template.StringMap;
+import com.linkedin.dataset.DatasetProperties;
+import com.linkedin.schema.ArrayType;
+import com.linkedin.schema.BooleanType;
+import com.linkedin.schema.BytesType;
+import com.linkedin.schema.EnumType;
+import com.linkedin.schema.FixedType;
+import com.linkedin.schema.MapType;
+import com.linkedin.schema.NullType;
+import com.linkedin.schema.NumberType;
+import com.linkedin.schema.OtherSchema;
+import com.linkedin.schema.RecordType;
+import com.linkedin.schema.SchemaField;
+import com.linkedin.schema.SchemaFieldArray;
+import com.linkedin.schema.SchemaFieldDataType;
+import com.linkedin.schema.SchemaMetadata;
+import com.linkedin.schema.StringType;
+import com.linkedin.schema.UnionType;
+import datahub.client.rest.RestEmitter;
+import datahub.event.MetadataChangeProposalWrapper;
+import org.apache.avro.AvroTypeException;
+import org.apache.avro.Schema;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.parquet.schema.MessageType;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class DataHubSyncClient extends AbstractSyncHoodieClient {
+
+ private final HoodieTimeline activeTimeline;
+ private final DataHubSyncConfig syncConfig;
+ private final Configuration hadoopConf;
+ private final DatasetUrn datasetUrn;
+
+ public DataHubSyncClient(DataHubSyncConfig syncConfig, Configuration
hadoopConf, FileSystem fs) {
+ super(syncConfig.basePath, syncConfig.assumeDatePartitioning,
syncConfig.useFileListingFromMetadata, false, fs);
+ this.syncConfig = syncConfig;
+ this.hadoopConf = hadoopConf;
+ this.datasetUrn = syncConfig.datasetIdentifier.getDatasetUrn();
+ this.activeTimeline =
metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants();
+ }
+
+ @Override
+ public void createTable(String tableName,
+ MessageType storageSchema,
+ String inputFormatClass,
+ String outputFormatClass,
+ String serdeClass,
+ Map<String, String> serdeProperties,
+ Map<String, String> tableProperties) {
+ throw new UnsupportedOperationException("Not supported: `createTable`");
+ }
+
+ @Override
+ public boolean doesTableExist(String tableName) {
+ return tableExists(tableName);
+ }
+
+ @Override
+ public boolean tableExists(String tableName) {
+ throw new UnsupportedOperationException("Not supported: `tableExists`");
+ }
+
+ @Override
+ public Option<String> getLastCommitTimeSynced(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`getLastCommitTimeSynced`");
+ }
+
+ @Override
+ public void updateLastCommitTimeSynced(String tableName) {
+ updateTableProperties(tableName,
Collections.singletonMap(HOODIE_LAST_COMMIT_TIME_SYNC,
activeTimeline.lastInstant().get().getTimestamp()));
+ }
+
+ @Override
+ public Option<String> getLastReplicatedTime(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`getLastReplicatedTime`");
+ }
+
+ @Override
+ public void updateLastReplicatedTimeStamp(String tableName, String
timeStamp) {
+ throw new UnsupportedOperationException("Not supported:
`updateLastReplicatedTimeStamp`");
+ }
+
+ @Override
+ public void deleteLastReplicatedTimeStamp(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`deleteLastReplicatedTimeStamp`");
+ }
+
+ @Override
+ public void addPartitionsToTable(String tableName, List<String>
partitionsToAdd) {
+ throw new UnsupportedOperationException("Not supported:
`addPartitionsToTable`");
+ }
+
+ @Override
+ public void updatePartitionsToTable(String tableName, List<String>
changedPartitions) {
+ throw new UnsupportedOperationException("Not supported:
`updatePartitionsToTable`");
+ }
+
+ @Override
+ public void dropPartitionsToTable(String tableName, List<String>
partitionsToDrop) {
+ throw new UnsupportedOperationException("Not supported:
`dropPartitionsToTable`");
+ }
+
+ @Override
+ public void updateTableProperties(String tableName, Map<String, String>
tableProperties) {
+ MetadataChangeProposalWrapper propertiesChangeProposal =
MetadataChangeProposalWrapper.builder()
+ .entityType("dataset")
+ .entityUrn(datasetUrn)
+ .upsert()
+ .aspect(new DatasetProperties().setCustomProperties(new
StringMap(tableProperties)))
+ .build();
+
+ try (RestEmitter emitter = syncConfig.getRestEmitter()) {
+ emitter.emit(propertiesChangeProposal, null).get();
+ } catch (Exception e) {
+ throw new HoodieDataHubSyncException("Fail to change properties for
Dataset " + datasetUrn + ": " + tableProperties, e);
+ }
+ }
+
+ public void updateTableDefinition(String tableName) {
Review comment:
do we need override here ?
##########
File path:
hudi-sync/hudi-datahub-sync/src/main/java/org/apache/hudi/sync/datahub/DataHubSyncClient.java
##########
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.sync.datahub;
+
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.TableSchemaResolver;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.sync.common.AbstractSyncHoodieClient;
+import org.apache.hudi.sync.common.HoodieSyncException;
+import org.apache.hudi.sync.datahub.config.DataHubSyncConfig;
+
+import com.linkedin.common.urn.DatasetUrn;
+import com.linkedin.data.template.SetMode;
+import com.linkedin.data.template.StringMap;
+import com.linkedin.dataset.DatasetProperties;
+import com.linkedin.schema.ArrayType;
+import com.linkedin.schema.BooleanType;
+import com.linkedin.schema.BytesType;
+import com.linkedin.schema.EnumType;
+import com.linkedin.schema.FixedType;
+import com.linkedin.schema.MapType;
+import com.linkedin.schema.NullType;
+import com.linkedin.schema.NumberType;
+import com.linkedin.schema.OtherSchema;
+import com.linkedin.schema.RecordType;
+import com.linkedin.schema.SchemaField;
+import com.linkedin.schema.SchemaFieldArray;
+import com.linkedin.schema.SchemaFieldDataType;
+import com.linkedin.schema.SchemaMetadata;
+import com.linkedin.schema.StringType;
+import com.linkedin.schema.UnionType;
+import datahub.client.rest.RestEmitter;
+import datahub.event.MetadataChangeProposalWrapper;
+import org.apache.avro.AvroTypeException;
+import org.apache.avro.Schema;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.parquet.schema.MessageType;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class DataHubSyncClient extends AbstractSyncHoodieClient {
+
+ private final HoodieTimeline activeTimeline;
+ private final DataHubSyncConfig syncConfig;
+ private final Configuration hadoopConf;
+ private final DatasetUrn datasetUrn;
+
+ public DataHubSyncClient(DataHubSyncConfig syncConfig, Configuration
hadoopConf, FileSystem fs) {
+ super(syncConfig.basePath, syncConfig.assumeDatePartitioning,
syncConfig.useFileListingFromMetadata, false, fs);
+ this.syncConfig = syncConfig;
+ this.hadoopConf = hadoopConf;
+ this.datasetUrn = syncConfig.datasetIdentifier.getDatasetUrn();
+ this.activeTimeline =
metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants();
+ }
+
+ @Override
+ public void createTable(String tableName,
+ MessageType storageSchema,
+ String inputFormatClass,
+ String outputFormatClass,
+ String serdeClass,
+ Map<String, String> serdeProperties,
+ Map<String, String> tableProperties) {
+ throw new UnsupportedOperationException("Not supported: `createTable`");
+ }
+
+ @Override
+ public boolean doesTableExist(String tableName) {
+ return tableExists(tableName);
+ }
+
+ @Override
+ public boolean tableExists(String tableName) {
+ throw new UnsupportedOperationException("Not supported: `tableExists`");
+ }
+
+ @Override
+ public Option<String> getLastCommitTimeSynced(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`getLastCommitTimeSynced`");
+ }
+
+ @Override
+ public void updateLastCommitTimeSynced(String tableName) {
+ updateTableProperties(tableName,
Collections.singletonMap(HOODIE_LAST_COMMIT_TIME_SYNC,
activeTimeline.lastInstant().get().getTimestamp()));
+ }
+
+ @Override
+ public Option<String> getLastReplicatedTime(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`getLastReplicatedTime`");
+ }
+
+ @Override
+ public void updateLastReplicatedTimeStamp(String tableName, String
timeStamp) {
+ throw new UnsupportedOperationException("Not supported:
`updateLastReplicatedTimeStamp`");
+ }
+
+ @Override
+ public void deleteLastReplicatedTimeStamp(String tableName) {
+ throw new UnsupportedOperationException("Not supported:
`deleteLastReplicatedTimeStamp`");
+ }
+
+ @Override
+ public void addPartitionsToTable(String tableName, List<String>
partitionsToAdd) {
+ throw new UnsupportedOperationException("Not supported:
`addPartitionsToTable`");
+ }
+
+ @Override
+ public void updatePartitionsToTable(String tableName, List<String>
changedPartitions) {
+ throw new UnsupportedOperationException("Not supported:
`updatePartitionsToTable`");
+ }
+
+ @Override
+ public void dropPartitionsToTable(String tableName, List<String>
partitionsToDrop) {
+ throw new UnsupportedOperationException("Not supported:
`dropPartitionsToTable`");
+ }
+
+ @Override
+ public void updateTableProperties(String tableName, Map<String, String>
tableProperties) {
+ MetadataChangeProposalWrapper propertiesChangeProposal =
MetadataChangeProposalWrapper.builder()
+ .entityType("dataset")
+ .entityUrn(datasetUrn)
+ .upsert()
+ .aspect(new DatasetProperties().setCustomProperties(new
StringMap(tableProperties)))
+ .build();
+
+ try (RestEmitter emitter = syncConfig.getRestEmitter()) {
+ emitter.emit(propertiesChangeProposal, null).get();
+ } catch (Exception e) {
+ throw new HoodieDataHubSyncException("Fail to change properties for
Dataset " + datasetUrn + ": " + tableProperties, e);
+ }
+ }
+
+ public void updateTableDefinition(String tableName) {
+ Schema avroSchema = getAvroSchemaWithoutMetadataFields(metaClient);
+ List<SchemaField> fields = avroSchema.getFields().stream().map(f -> new
SchemaField()
+ .setFieldPath(f.name())
+ .setType(toSchemaFieldDataType(f.schema().getType()))
+ .setDescription(f.doc(), SetMode.IGNORE_NULL)
+
.setNativeDataType(f.schema().getType().getName())).collect(Collectors.toList());
+
+ final SchemaMetadata.PlatformSchema platformSchema = new
SchemaMetadata.PlatformSchema();
+ platformSchema.setOtherSchema(new
OtherSchema().setRawSchema(avroSchema.toString()));
+ MetadataChangeProposalWrapper schemaChangeProposal =
MetadataChangeProposalWrapper.builder()
+ .entityType("dataset")
+ .entityUrn(datasetUrn)
+ .upsert()
+ .aspect(new SchemaMetadata()
+ .setSchemaName(tableName)
+ .setVersion(0)
+ .setHash("")
+ .setPlatform(datasetUrn.getPlatformEntity())
+ .setPlatformSchema(platformSchema)
+ .setFields(new SchemaFieldArray(fields)))
+ .build();
+
+ try (RestEmitter emitter = syncConfig.getRestEmitter()) {
+ emitter.emit(schemaChangeProposal, null).get();
+ } catch (Exception e) {
+ throw new HoodieDataHubSyncException("Fail to change schema for Dataset
" + datasetUrn, e);
+ }
+ }
+
+ @Override
+ public Map<String, String> getTableSchema(String tableName) {
+ throw new UnsupportedOperationException("Not supported: `getTableSchema`");
+ }
+
+ @Override
+ public void close() {
+ // no op;
+ }
+
+ static Schema getAvroSchemaWithoutMetadataFields(HoodieTableMetaClient
metaClient) {
+ try {
+ return new TableSchemaResolver(metaClient).getTableAvroSchema(false);
Review comment:
lets get the metadata fields as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
