bhasudha commented on a change in pull request #1290: [HUDI-584] Relocate
spark-avro dependency by maven-shade-plugin
URL: https://github.com/apache/incubator-hudi/pull/1290#discussion_r386190496
##########
File path: packaging/hudi-spark-bundle/pom.xml
##########
@@ -248,6 +260,13 @@
<spark.bundle.hive.shade.prefix>org.apache.hudi.</spark.bundle.hive.shade.prefix>
</properties>
</profile>
+ <profile>
+ <id>spark-shade-unbundle-avro</id>
+ <properties>
+ <spark.bundle.avro.scope>provided</spark.bundle.avro.scope>
+ <spark.bundle.spark.shade.prefix>/</spark.bundle.spark.shade.prefix>
Review comment:
@lamber-ken I see a '/' here for the property
"spark.bundle.spark.shade.prefix" if the profile is activated. Is this
intended? Does this mean shade with empty prefix (same as not shading)? I dont
know much about profiling either so wanted to clarify with you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
