codope commented on a change in pull request #4693:
URL: https://github.com/apache/hudi/pull/4693#discussion_r835775436



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/bloom/BloomFilter.java
##########
@@ -30,6 +34,13 @@
    */
   void add(String key);
 
+  /**
+   * Add secondary key to the {@link BloomFilter}.
+   *
+   * @param keys list of secondary keys to add to the {@link BloomFilter}
+   */
+  void add(@Nonnull List<String> keys);

Review comment:
       it's just a wrapper to call the original `add(Key)`.. membership test 
will still happen per key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to