yanghua commented on a change in pull request #1354: [WIP][HUDI-581] NOTICE need more work as it missing content form included 3rd party ALv2 licensed NOTICE files URL: https://github.com/apache/incubator-hudi/pull/1354#discussion_r384980154
########## File path: NOTICE ########## @@ -3,3 +3,9 @@ Copyright 2020 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache-2 license. +See bundled license files for details. + - compress-lzf:1.0.3 Review comment: It seems it is not necessary to list the artifacts which follow the Apache License. I did some research based on https://github.com/apache/dubbo/blob/master/NOTICE, https://github.com/apache/incubator-shardingsphere/blob/master/NOTICE and Flink. We only need to list those artifacts that follow the other license(e.g. BSD) and so on. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
