xushiyan commented on a change in pull request #4888:
URL: https://github.com/apache/hudi/pull/4888#discussion_r832942841
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala
##########
@@ -104,7 +104,7 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
// NOTE: This is required to compensate for cases when empty string is
used to stub
// property value to avoid it being set with the default value
// TODO(HUDI-3456) cleanup
- case Some(f) if !StringUtils.isNullOrEmpty(f) => Some(f)
+ case Some(f) if StringUtils.nonEmpty(f) => Some(f)
Review comment:
this method `nonEmpty()` does not exist yet. i should have clarified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
