yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383633637
########## File path: hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientBase.java ########## @@ -16,8 +16,10 @@ * limitations under the License. */ -package org.apache.hudi; +package org.apache.hudi.client; +import org.apache.hudi.common.HoodieClientTestHarness; +import org.apache.hudi.WriteStatus; Review comment: Actually, I agree with the context like `SparkContext` can be placed under the top-level package. However, IMO, the `WriteStatus` is not as important as `SparkContext`. It is not been used anywhere. Hudi support `write` and `read` operation. We should make them a pair relationship. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
