guanziyue commented on a change in pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#discussion_r830581973
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestBoundedInMemoryExecutorInSpark.java
##########
@@ -152,6 +165,144 @@ protected Integer getResult() {
} finally {
if (executor != null) {
executor.shutdownNow();
+ executor.awaitTermination();
+ }
+ }
+ }
+
+ @Test
+ public void testExecutorTermination() throws ExecutionException,
InterruptedException {
Review comment:
Do think about this. This test cannot achieve the goal to find out if a
code change can reproduce this problem. Make this UT more simple which just
validate termination and awaiting works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
