xiarixiaoyao commented on pull request #3808: URL: https://github.com/apache/hudi/pull/3808#issuecomment-1069199465
> Nit comments. Overall looks good. Once, you are done with the changes, I will approve the diff. Looking into the Spark PR on top of this. > > @xiarixiaoyao : We need one diff to document the usage and constraints (for eg: Hoodie columns should not be reordered, nested types ) of Alter commands as a section in Apache Hudi website. @bvaradar Thank you very much for your comments yes, hoodie internal columns should not be modified, We have already prohibited these situations in our code, and we can find the test code in TestSpark3DDL. this pr https://github.com/apache/hudi/pull/4910 yes, i will prepare a doc for alter commands -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org