prashantwason commented on a change in pull request #4693:
URL: https://github.com/apache/hudi/pull/4693#discussion_r824571450
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -118,18 +124,18 @@
/**
* Hudi backed table metadata writer.
*
- * @param hadoopConf - Hadoop configuration to use for the
metadata writer
- * @param writeConfig - Writer config
- * @param engineContext - Engine context
- * @param actionMetadata - Optional action metadata to help decide
bootstrap operations
- * @param <T> - Action metadata types extending Avro
generated SpecificRecordBase
+ * @param hadoopConf - Hadoop configuration to use for the metadata writer
+ * @param writeConfig - Writer config
+ * @param engineContext - Engine context
+ * @param actionMetadata - Optional action metadata to help decide bootstrap
operations
+ * @param <T> - Action metadata types extending Avro generated
SpecificRecordBase
* @param inflightInstantTimestamp - Timestamp of any instant in progress
*/
protected <T extends SpecificRecordBase>
HoodieBackedTableMetadataWriter(Configuration hadoopConf,
-
HoodieWriteConfig writeConfig,
-
HoodieEngineContext engineContext,
-
Option<T> actionMetadata,
-
Option<String> inflightInstantTimestamp) {
+ HoodieWriteConfig writeConfig,
Review comment:
+1 as we lose commit history of these lines and it bloats the diffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
