xushiyan commented on a change in pull request #4962:
URL: https://github.com/apache/hudi/pull/4962#discussion_r824386018



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -137,4 +165,20 @@
       throw new HoodieIOException("Unable to read metadata for instant " + 
hoodieInstantOption.get(), io);
     }
   }
+
+  /**
+   * Get pending clustering instant.
+   * Notice:
+   *   we return .requested instant here.
+   *
+   * @param metaClient
+   * @return
+   */
+  public static List<HoodieInstant> 
getUncheckedPendingClusteringInstants(HoodieTableMetaClient metaClient) {

Review comment:
       shall we call it "ReplaceRequestedInstant" to be specific? Also 
"unchecked" is only in the context of write client; `TransactionUtils` does not 
know "unchecked" or not.
   
   ```suggestion
     public static List<HoodieInstant> 
getPendingReplaceRequestedInstants(HoodieTableMetaClient metaClient) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to