nsivabalan commented on a change in pull request #4905:
URL: https://github.com/apache/hudi/pull/4905#discussion_r818076410
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestDataSourceUtils.java
##########
@@ -222,6 +224,26 @@ public void
testCreateRDDCustomColumnsSortPartitionerWithValidPartitioner() thro
assertThat(partitioner.isPresent(), is(true));
}
+ @Test
+ public void testCreateHoodieConfigWithAsyncClustering() {
+ ArrayList<ImmutablePair<String, Boolean>> asyncClusteringKeyValues = new
ArrayList<>(4);
+ asyncClusteringKeyValues.add(new
ImmutablePair(DataSourceWriteOptions.ASYNC_CLUSTERING_ENABLE().key(), true));
+ asyncClusteringKeyValues.add(new
ImmutablePair(HoodieClusteringConfig.ASYNC_CLUSTERING_ENABLE.key(), true));
+ asyncClusteringKeyValues.add(new
ImmutablePair("hoodie.datasource.clustering.async.enable", true));
+ asyncClusteringKeyValues.add(new
ImmutablePair("hoodie.clustering.async.enabled", true));
+
+ asyncClusteringKeyValues.stream().forEach(pair -> {
+ HashMap<String, String> params = new HashMap<>(3);
+ params.put(DataSourceWriteOptions.TABLE_TYPE().key(),
DataSourceWriteOptions.TABLE_TYPE().defaultValue());
+ params.put(DataSourceWriteOptions.PAYLOAD_CLASS_NAME().key(),
+ DataSourceWriteOptions.PAYLOAD_CLASS_NAME().defaultValue());
+ params.put(pair.left, pair.right.toString());
+ HoodieWriteConfig hoodieConfig = DataSourceUtils
+ .createHoodieConfig(avroSchemaString, config.getBasePath(),
"test", params);
+ assertEquals(pair.right, hoodieConfig.isAsyncClusteringEnabled());
+ });
Review comment:
can you also add assertion for this
```
HoodieClusteringConfig.from(props).isAsyncClusteringEnabled()
```
this is what we use in DeltaStreamer code path. should work. but would be
good to cover in tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
