danny0405 commented on a change in pull request #4880:
URL: https://github.com/apache/hudi/pull/4880#discussion_r816403232
##########
File path:
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala
##########
@@ -516,17 +516,14 @@ class TestMORDataSource extends HoodieClientTestBase {
checkAnswer((1, "a0", 12, 101, false))
writeData((1, "a0", 16, 97, true))
- // Ordering value will not be honored for a delete record as the payload
is sent as empty payload
- checkAnswer((1, "a0", 16, 97, true))
+ // Ordering value will be honored, the delete record is considered as
obsolete
+ // because it has smaller version number (97 < 101)
+ checkAnswer((1, "a0", 12, 101, false))
writeData((1, "a0", 18, 96, false))
- // Ideally, once a record is deleted, preCombine does not kick. So, any
new record will be considered valid ignoring
- // ordering val. But what happens ini hudi is, all records in log files
are reconciled and then merged with base
Review comment:
This test describes is just so weird because it tries to explain why the
error/unexpected case happens, i don't think there is any necessity to keep it.
If you think the fix the hard to understand, let's make it clear in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
