stayrascal commented on pull request #4724:
URL: https://github.com/apache/hudi/pull/4724#issuecomment-1047016868


   Hi @danny0405 , regarding the two changes:
   - embedding schema in payload might hard to do schema evolution later.
   - using flink state to store full HoodieRecord instead of location, will 
increase the state size.
   
   for first one, I remove the schema filed from payload class, instead, by 
passing the schema to `preCombine` method, it should be easy to do schema 
evolution if need.
   for second one, I revert my changes about store whole HoodieRecord back to 
store location, it still has the problem that once the record partition path 
changed, but i think it should enough for supporting the case that the table 
don't have partition, or the partition path of record won't changed.
   
   BTW, do you think is it worthy to implement a new bucket assign function(can 
be controlled by feature toggle/configuration ) which store the full record to 
support partial update totally ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to