codope commented on a change in pull request #4712:
URL: https://github.com/apache/hudi/pull/4712#discussion_r808174759
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -228,13 +228,20 @@ public HoodieTableConfig() {
private void fetchConfigs(FileSystem fs, String metaPath) throws IOException
{
Path cfgPath = new Path(metaPath, HOODIE_PROPERTIES_FILE);
+ Path backupCfgPath = new Path(metaPath, HOODIE_PROPERTIES_FILE_BACKUP);
try (FSDataInputStream is = fs.open(cfgPath)) {
props.load(is);
+ // validate checksum and upgrade
+ if (!contains(TABLE_CHECKSUM.key()) || !validateChecksum(props)) {
Review comment:
Good point! I am thinking if we check for table version, validate
checksum in `fetchConfigs` only if it's latest table version.
Btw, do you know how we have handled this in the past?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
