xushiyan commented on a change in pull request #4824:
URL: https://github.com/apache/hudi/pull/4824#discussion_r807877795
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -762,12 +769,12 @@ protected Boolean
onInitializingWriteClient(SparkRDDWriteClient writeClient) {
List<HoodieInstant> pending =
ClusteringUtils.getPendingClusteringInstantTimes(meta);
LOG.info(String.format("Found %d pending clustering instants ",
pending.size()));
pending.forEach(hoodieInstant ->
asyncClusteringService.get().enqueuePendingAsyncServiceInstant(hoodieInstant));
- asyncClusteringService.get().start((error) -> {
- shutdown(false);
- return true;
- });
+ asyncClusteringService.get().start((error) -> true);
Review comment:
minor stuff
```suggestion
asyncClusteringService.get().start(error -> true);
```
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncService.java
##########
@@ -203,7 +211,7 @@ public void enqueuePendingAsyncServiceInstant(HoodieInstant
instant) {
*/
HoodieInstant fetchNextAsyncServiceInstant() throws InterruptedException {
LOG.info("Waiting for next instant upto 10 seconds");
Review comment:
use `POLLING_SECONDS` here?
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -659,13 +659,20 @@ public DeltaSync getDeltaSync() {
asyncCompactService.get().enqueuePendingAsyncServiceInstant(new
HoodieInstant(State.REQUESTED,
HoodieTimeline.COMPACTION_ACTION,
scheduledCompactionInstantAndRDD.get().getLeft().get()));
asyncCompactService.get().waitTillPendingAsyncServiceInstantsReducesTo(cfg.maxPendingCompactions);
+ if (asyncCompactService.get().hasError()) {
+ throw new HoodieException("Async compaction failed.
Shutting down Delta Sync...");
+ }
}
if (clusteringConfig.isAsyncClusteringEnabled()) {
Option<String> clusteringInstant =
deltaSync.getClusteringInstantOpt();
if (clusteringInstant.isPresent()) {
LOG.info("Scheduled async clustering for instant: " +
clusteringInstant.get());
asyncClusteringService.get().enqueuePendingAsyncServiceInstant(new
HoodieInstant(State.REQUESTED, HoodieTimeline.REPLACE_COMMIT_ACTION,
clusteringInstant.get()));
asyncClusteringService.get().waitTillPendingAsyncServiceInstantsReducesTo(cfg.maxPendingClustering);
+ if (asyncClusteringService.get().hasError()) {
+ error = true;
Review comment:
is this needed? why only assign delta streamer's flag here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
