YuweiXiao commented on a change in pull request #4823:
URL: https://github.com/apache/hudi/pull/4823#discussion_r807658087
##########
File path:
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/commit/JavaUpsertPartitioner.java
##########
@@ -205,6 +205,11 @@ private void assignInserts(WorkloadProfile profile,
HoodieEngineContext context)
private Map<String, List<SmallFile>> getSmallFilesForPartitions(List<String>
partitionPaths, HoodieEngineContext context) {
Map<String, List<SmallFile>> partitionSmallFilesMap = new HashMap<>();
+
+ if (config.getParquetSmallFileLimit() == 0) {
Review comment:
How about using <= 0 to indicate always writing to new file group? And
maybe add a description of this behavior to the document of
`PARQUET_SMALL_FILE_LIMIT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
