danny0405 commented on a change in pull request #4791:
URL: https://github.com/apache/hudi/pull/4791#discussion_r804433456
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/TypedProperties.java
##########
@@ -44,27 +43,22 @@ public TypedProperties(Properties defaults) {
}
private void checkKey(String property) {
- if (!keyExists(property)) {
+ if (!containsKey(property)) {
throw new IllegalArgumentException("Property " + property + " not
found");
Review comment:
The old code requires that the key should be a string, what about the
new code then ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
