pratyakshsharma commented on a change in pull request #4385:
URL: https://github.com/apache/hudi/pull/4385#discussion_r801363902
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java
##########
@@ -1148,7 +1167,9 @@ public void testKeepLatestCommits(boolean
simulateFailureRetry, boolean enableIn
.withIncrementalCleaningMode(enableIncrementalClean)
.withFailedWritesCleaningPolicy(HoodieFailedWritesCleaningPolicy.EAGER)
.withCleanBootstrapBaseFileEnabled(enableBootstrapSourceClean)
-
.withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS).retainCommits(2).build())
+ .withCleanerPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
+ .retainCommits(2)
Review comment:
I am fine with adding a new class for testing this.
`TestCleanPlanExecutor` can have `testInvalidCleaningTriggerStrategy()`.
But adding the happy flow there will lead to code duplication since I need to
simulate the commit timeline exactly as is to be able to show the working of
this cleaner trigger strategy. Please let me know and I will do the needful.
@nsivabalan @vinothchandar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
