manojpec commented on a change in pull request #4352: URL: https://github.com/apache/hudi/pull/4352#discussion_r793420768
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieIOHandle.java ########## @@ -31,8 +33,8 @@ protected final FileSystem fs; protected final HoodieTable<T, I, K, O> hoodieTable; - HoodieIOHandle(HoodieWriteConfig config, String instantTime, HoodieTable<T, I, K, O> hoodieTable) { - this.instantTime = instantTime; + HoodieIOHandle(HoodieWriteConfig config, Option<String> instantTime, HoodieTable<T, I, K, O> hoodieTable) { + this.instantTime = instantTime.orElse(StringUtils.EMPTY_STRING); Review comment: For ReadHandle instant time is not used. Just avoiding the use of null by the callers and the checking against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org