dongkelun commented on a change in pull request #4083:
URL: https://github.com/apache/hudi/pull/4083#discussion_r788499208



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/InputPathHandler.java
##########
@@ -53,25 +57,27 @@
   public static final Logger LOG = 
LogManager.getLogger(InputPathHandler.class);
 
   private final Configuration conf;
-  // tablename to metadata mapping for all Hoodie tables(both incremental & 
snapshot)
+  // tableName to metadata mapping for all Hoodie tables(both incremental & 
snapshot)
   private final Map<String, HoodieTableMetaClient> tableMetaClientMap;
   private final Map<HoodieTableMetaClient, List<Path>> groupedIncrementalPaths;
   private final List<Path> snapshotPaths;
   private final List<Path> nonHoodieInputPaths;
+  private boolean isIncrementalUseDatabase;
 
-  public InputPathHandler(Configuration conf, Path[] inputPaths, List<String> 
incrementalTables) throws IOException {
+  public InputPathHandler(Configuration conf, Path[] inputPaths, List<String> 
incrementalTables, JobConf job) throws IOException {
     this.conf = conf;
     tableMetaClientMap = new HashMap<>();
     snapshotPaths = new ArrayList<>();
     nonHoodieInputPaths = new ArrayList<>();
     groupedIncrementalPaths = new HashMap<>();
+    this.isIncrementalUseDatabase = 
HoodieHiveUtils.isIncrementalUseDatabase(Job.getInstance(job));

Review comment:
       Yes, We can. Thank you for your reminder. That's a good idea




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to