XuQianJin-Stars commented on issue #1095: [HUDI-210] Implement prometheus metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1095#issuecomment-564471341 > hi, Thanks for opening the PR @XuQianJin-Stars, this test case is useless. Because PushGateway use `io.prometheus.client.Gauge` instead of `com.codahale.metrics.Gauge`. > It need to regist `io.prometheus.client.Gauge` firstly, after that we can send these metrics. > > For example, `MetricRegistry registry = new MetricRegistry();` belllow is redundant. > > ``` > PushGateway pushGateway = new PushGateway("localhost:9091"); > > > MetricRegistry registry = new MetricRegistry(); > registry.register("push_gateway1", (Gauge<Long>) () -> 123L); > > > io.prometheus.client.Gauge submitActiveTasksGauge = io.prometheus.client.Gauge.build() > .name("active_tasks") > .help("active_tasks").register(); > submitActiveTasksGauge.set(5L); > > pushGateway.push(CollectorRegistry.defaultRegistry, "PushGateway"); > ``` well, you are right. I will remove this test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
