arw357 commented on a change in pull request #960: [HUDI-307] Adding type test
for timestamp,date & decimal
URL: https://github.com/apache/incubator-hudi/pull/960#discussion_r336537682
##########
File path:
hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -200,13 +281,17 @@ public static void createSavepointFile(String basePath,
String commitTime, Confi
* Generates new inserts, uniformly across the partition paths above. It
also updates the list of existing keys.
*/
public List<HoodieRecord> generateInserts(String commitTime, Integer n)
throws IOException {
- return generateInsertsStream(commitTime, n).collect(Collectors.toList());
+ return generateInsertsStream(commitTime,
n,false).collect(Collectors.toList());
+ }
+
+ public List<HoodieRecord> generateExtraTypesInserts(String commitTime,
Integer n) throws IOException {
+ return generateInsertsStream(commitTime,
n,true).collect(Collectors.toList());
}
/**
* Generates new inserts, uniformly across the partition paths above. It
also updates the list of existing keys.
*/
- public Stream<HoodieRecord> generateInsertsStream(String commitTime, Integer
n) {
+ public Stream<HoodieRecord> generateInsertsStream(String commitTime, Integer
n, Boolean extraType) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
