nevzheng commented on issue #13900: URL: https://github.com/apache/gravitino/issues/13900#issuecomment-6340511794
S0 is ready for review: four test-toolchain PRs, no design decisions. They move our tests onto JUnit 6 and Testcontainers 2, the base the rest of #13900 builds on. Please review and merge bottom-up; each PR reverts on its own. 1. #14103: Replace the last JUnit 4 code and declare the test libraries each module uses. 44 files move to Jupiter, and `TestOwnerDetails`, which was silently skipped, now runs. Each module declares the test libraries it imports instead of getting them transitively, and checkstyle bans `org.junit.*` outside Jupiter/Platform. 2. #14083: JUnit 5.8.1 → 6.1.3. One BOM for every test configuration; stray per-module JUnit pins removed. 3. #14084: Testcontainers 1.21.4 → 2.0.5. Fixes #13958. The trino-connector modules stay on 1.x through Trino’s own test harness. 4. #14085: BackendTestExtension cleans up through JUnit’s store. Closes #14105. Why it matters: Testcontainers 2 drops `junit:junit`, so tests that only got a library transitively break. #14103 fixes that class of breakage for good by having each module declare what it uses. Verified: * 10,711 unit tests in CI’s build job, zero failures. * Docker ITs green across 16 modules at the top of the stack. * CI green on all four PRs: [#14103](https://github.com/apache/gravitino/pull/14103/checks), [#14083](https://github.com/apache/gravitino/pull/14083/checks), [#14084](https://github.com/apache/gravitino/pull/14084/checks), [#14085](https://github.com/apache/gravitino/pull/14085/checks). * #14085 needs a rerun of PythonIT: its teardown hit `OSError: Directory not empty` while removing the server data directory, unrelated to this change. Next: the design doc (#14005) goes out with the first framework PRs once S0 lands. @jerryshao @roryqi PTAL when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
