yuqi1129 commented on PR #13049: URL: https://github.com/apache/gravitino/pull/13049#issuecomment-6334471004
@jerryshao Thanks for the review. I've replied to all eight inline comments with the corresponding fixes in f6f9db500d and effa17fc17. For the two review-level items: - Consolidated the Backend, Spark, Flink and Maintenance PR/push jobs into one matrix gated on `source_changes`; the dead `*-on-pr` copies are removed. - Kept first-party major tags: [ASF policy](https://infra.apache.org/github-actions-policy.html#external-actions) exempts `actions/*`, `github/*` and `apache/*` from the external-action SHA requirement, and [Infra's guidance](https://infra.apache.org/services.html#github-actions) recommends major tags for first-party actions. The privileged publisher no longer uses cache restore/save at all. This rationale is recorded in CONTRIBUTING and the PR description. Validation: 24 Node regression tests, actionlint, YAML/shell syntax checks, and a Git smoke test of the actual frozen-base merge script passed. Independent re-review found no remaining Blocker/Important. The new fork run is still pending completion, and the trusted publishers/scanner and branch-protection cutover require coordinated default-branch rollout; I haven't treated those as already validated. Could you take another look at the updated head when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
