diqiu50 opened a new pull request, #14080:
URL: https://github.com/apache/gravitino/pull/14080

   ### What changes were proposed in this pull request?
   
   Reject path-based token credential providers (`s3-token`, `oss-token`, 
`gcs-token`, `adls-token`, `cos-token`) when creating or altering a catalog 
that cannot provide path-based credential contexts. Only Fileset and Iceberg 
catalogs support them. Also correct the supported catalogs table in the 
credential vending docs.
   
   ### Why are the changes needed?
   
   Token providers return no credentials for a catalog-level context. A Hive 
catalog configured with `gcs-token` is accepted, but every engine query then 
fails with a storage authorization error. The docs also list Hive as vending 
GCS.
   
   Fix: #14069
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Creating or altering a catalog other than Fileset and Iceberg with a 
token provider now fails with an error naming the provider and the catalog 
type. Existing catalogs still load.
   
   ### How was this patch tested?
   
   Added unit tests in `TestBaseCatalogCredentialProviders`, 
`TestCatalogManager`, `TestFilesetCatalogCredential` and `TestIcebergCatalog`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to