diqiu50 opened a new pull request, #14053:
URL: https://github.com/apache/gravitino/pull/14053

   ### What changes were proposed in this pull request?
   
   Treat a null comment in `UpdateComment` / `UpdateColumnComment` as an empty 
comment in JDBC catalogs, so it clears the comment. ClickHouse uses `COMMENT 
COLUMN` to clear a column comment, since `MODIFY COLUMN` without a `COMMENT` 
clause keeps the existing one.
   
   ### Why are the changes needed?
   
   A null comment wrote the literal text "null" on PostgreSQL, Doris, MySQL, 
StarRocks and OceanBase, and threw NullPointerException on Hologres and 
ClickHouse.
   
   Fix: #14048
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Updating a table or column comment with null now clears the comment.
   
   ### How was this patch tested?
   
   Added SQL generation unit tests for each dialect and Docker tests that 
verify the comment is cleared on real databases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to