jerryshao commented on PR #14023: URL: https://github.com/apache/gravitino/pull/14023#issuecomment-6306793649
Addressed the review in 40131ad4a7. The three inline threads are answered. On the test gaps from the summary: - The first `ASYNC_SHARED` listener added after `start()` (no `default` queue yet) is covered by `testFirstSharedListenerAddedAfterStart`. - `testStopInterruptsDispatcherThatDoesNotFinishInTime` now checks that `stop()` takes at least the drain timeout and stays well under twice `dispatcherJoinSeconds` plus margin. - `TestGravitinoEnvShutdown` checks that an async listener drains while the entity store is still open, and that aux services stop before the store closes. With the old shutdown order it fails (expected 1, was 0). _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
