yuqi1129 commented on code in PR #13975:
URL: https://github.com/apache/gravitino/pull/13975#discussion_r4332265808
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -1235,6 +1259,11 @@ private StringBuilder appendColumnDefinitionForModify(
}
private StringBuilder appendColumnDefinition(JdbcColumn column,
StringBuilder sqlBuilder) {
+ return appendColumnDefinition(column, sqlBuilder, false);
Review Comment:
Fixed in 89275584ef. Nullability and position changes now use the same
version-aware MODIFY COLUMN rendering as type changes, sharing one version
lookup per ALTER request. Added regression coverage for quoted/backslash
defaults on Doris 1.2, 2.1, 3.x and 4.x, plus checks that ordinary defaults
skip the version query.
##########
catalogs/catalog-jdbc-starrocks/src/main/java/org/apache/gravitino/catalog/starrocks/utils/StarRocksUtils.java:
##########
Review Comment:
Fixed in 89275584ef and 8aaf128c47. The property parser now recognizes
doubled and backslash-escaped quotes, so embedded quoted equals signs stay
inside the value. Possessive repetition also avoids stack overflow on long
properties. Added round-trip regression tests for the reported case, escaped
separators, whitespace and long values; applied the same fix to the symmetric
Doris parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
