diqiu50 opened a new pull request, #14004:
URL: https://github.com/apache/gravitino/pull/14004

   ### What changes were proposed in this pull request?
   
   Build the StarRocks `ADD COLUMN` clause with `appendColumnDefinition`, the 
same logic used by
   create table, so nullability and default value are applied. Reject 
auto-increment columns
   explicitly since StarRocks does not support adding them.
   
   ### Why are the changes needed?
   
   StarRocks add column silently dropped nullability, default value and 
auto-increment.
   
   Fix: #13999
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Added StarRocks columns now honor nullability and default value. Adding 
an auto-increment
   column now fails with a clear error.
   
   ### How was this patch tested?
   
   - Added unit tests in `TestStarRocksTableOperationsSqlGeneration`.
   - Extended `CatalogStarRocksIT#testColumnDefaultValue`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to