yuqi1129 opened a new pull request, #13924: URL: https://github.com/apache/gravitino/pull/13924
### What changes were proposed in this pull request? Reject non-empty index definitions in the StarRocks CREATE TABLE SQL generator before acquiring a database connection. Return an unsupported-operation error that tells the caller to remove the index definitions, and document this behavior. ### Why are the changes needed? The StarRocks connector silently ignores requested indexes, while the create response echoes them back. The catalog documentation already marks indexes as unsupported. Rejecting these requests prevents creating a table whose definition differs from the successful response. Fix: #13923 ### Does this PR introduce _any_ user-facing change? StarRocks create-table requests with non-empty `indexes` now fail explicitly. Null and empty index arrays retain their existing behavior. ### How was this patch tested? - Ran `./gradlew :catalogs:catalog-jdbc-starrocks:spotlessApply`. - Ran `./gradlew :catalogs:catalog-jdbc-starrocks:test -PskipITs -PskipDockerTests=true`: 34 tests passed with Docker tests excluded. - Added tests for all 21 index types, rejection before acquiring a connection, and unchanged SQL for null/empty index arrays. - Temporarily removed the validation: all 21 rejection cases failed as expected. Restored the fix and reran the module tests successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
