yuqi1129 opened a new pull request, #13917:
URL: https://github.com/apache/gravitino/pull/13917

   ### What changes were proposed in this pull request?
   
   Reject unsupported table purge in the StarRocks and OceanBase JDBC catalogs 
instead of executing `TRUNCATE TABLE`.
   
   Remove StarRocks' two-argument purge SQL override so the actual JDBC purge 
path reaches its existing unsupported-operation check. Make OceanBase report 
the same unsupported-operation contract. Add regression tests through `purge()` 
that verify the exception, no destructive SQL execution, and connection 
release; also verify ordinary `drop()` still executes `DROP TABLE`. Update the 
existing OceanBase integration test to expect unsupported purge for both 
present and absent tables and verify rejection preserves the existing table.
   
   ### Why are the changes needed?
   
   Both catalogs currently clear the data while retaining the table, then 
report `dropped: true`. This violates the table-purge contract and can cause 
Gravitino to remove its registration for a table that still exists.
   
   Fix: #13916
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Purge on these two catalogs now reports an unsupported-operation error 
instead of clearing table data and reporting successful deletion. Use ordinary 
drop to delete a table. This does not claim that ordinary drop skips the 
backend's recycle bin.
   
   ### How was this patch tested?
   
   - All non-Docker unit tests in both affected modules: 22 passed (StarRocks 
13, OceanBase 9).
   - Spotless checks and `git diff --check` passed.
   - Restored both old implementations temporarily: both new purge regressions 
failed because no unsupported-operation exception was thrown. The fixes were 
restored afterward.
   - Focused OceanBase Docker integration test 
`CatalogOceanBaseIT.testNameSpec`: 1 passed against a real OceanBase container 
and embedded Gravitino server.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to