lasdf1234 commented on PR #13858:
URL: https://github.com/apache/gravitino/pull/13858#issuecomment-6208036887

   @jerryshao 
   
   Shell `-c` truncation. The command is no longer cut at the first `=`. It is 
split on whitespace, each sensitive `key=value` is masked, and the rest of the 
command is kept. Skipping any payload that contains whitespace would leave 
`export db_password=pd && run.sh` in clear text, so that is not the fix.
   `ACCOUNT_ID` matches the existing `account` keyword, so that value should 
stay masked. Only the dropped command text is restored:
   - `-c "export ACCOUNT_ID=5 && run.sh --flag"` → `-c "export 
ACCOUNT_ID=****** && run.sh --flag"`
   - `-c "DB_PASSWORD=pw run.sh"` → `-c "DB_PASSWORD=****** run.sh"`
   - `-c "echo ready && run.sh --flag"` is unchanged
   - Spark `-c jdbc.password=secret-pw` (no space) is still fully masked


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to