LuciferYang opened a new issue, #13871:
URL: https://github.com/apache/gravitino/issues/13871

   ### What would you like to be improved?
   
   `IcebergHiveCachedClientPool.close()` closes every client in the JVM-wide 
static `clientPoolCache` and shuts down the shared eviction scheduler, so 
calling it on one instance would break the Hive clients of every Iceberg 
catalog in the process. Nothing calls it:
   
   - `ClosableHiveCatalog.closeInternalClientPool` skips 
`IcebergHiveCachedClientPool` explicitly.
   - The `oldPool instanceof AutoCloseable` branch in 
`resetIcebergHiveClientPool` never runs. `HiveCatalog.initialize` always sets 
`clients` to Iceberg's `CachedClientPool` before the reset, and `ClientPool` 
does not extend `AutoCloseable`.
   
   `ClosableHiveCatalog.addResource` and `getResources` have no callers either, 
so the loop in `close()` that closes them always iterates an empty list.
   
   ### How should we improve?
   
   Remove `Closeable` and `close()` from `IcebergHiveCachedClientPool`, the 
`AutoCloseable` branch in the reset path, and the `resources` list with 
`addResource`. Behavior does not change, and the shared cache can no longer be 
cleared by one catalog.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to