laserninja commented on code in PR #12900:
URL: https://github.com/apache/gravitino/pull/12900#discussion_r4261156426
##########
web-v2/web/src/app/catalogs/rightContent/entitiesContent/SchemaDetailsPage.js:
##########
@@ -631,6 +657,77 @@ export default function SchemaDetailsPage() {
[currentMetalake, catalogType, catalog, schema, catalogData?.provider]
)
+ const semanticModelColumns = useMemo(
+ () => [
+ {
+ title: 'Semantic Model Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 300,
+ ellipsis: true,
+ sorter: (a, b) =>
a?.name.toLowerCase().localeCompare(b?.name.toLowerCase()),
+ render: name => (
+ <Link
+ data-refer={`semantic-model-link-${name}`}
+
href={`/catalogs?metalake=${encodeURIComponent(currentMetalake)}&catalogType=${catalogType}&catalog=${encodeURIComponent(catalog)}&schema=${encodeURIComponent(schema)}&semanticModel=${encodeURIComponent(name)}`}
+ >
+ {name}
+ </Link>
+ )
+ },
+ {
+ title: 'Tags',
+ dataIndex: 'tags',
+ key: 'tags',
+ render: (_, record) => (
+ <Tags metadataObjectType={'semantic_model'}
metadataObjectFullName={`${catalog}.${schema}.${record.name}`} />
+ )
+ },
+ {
+ title: 'Actions',
+ dataIndex: 'action',
+ key: 'action',
+ width: 100,
+ render: (_, record) => (
+ <Space size={4}>
+ <a data-refer={`edit-semantic-model-${record.name}`}>
+ <Tooltip title='Edit'>
+ <Icons.Pencil
+ className='size-4 hover:cursor-pointer
hover:text-defaultPrimary'
+ onClick={() => {
+ setEditSemanticModel(record.name)
+ setOpenSemanticModel(true)
+ }}
+ />
+ </Tooltip>
+ </a>
+ <a data-refer={`delete-semantic-model-${record.name}`}>
+ <Tooltip title='Delete'>
+ <Icons.Trash2Icon
+ className='size-4 hover:cursor-pointer
hover:text-defaultPrimary'
+ onClick={() => showDeleteConfirm(record, 'semanticModel')}
+ />
+ </Tooltip>
+ </a>
+ {anthEnable && (
Review Comment:
Fixed in 2461081a2. Edit and Delete now use Ant Design icon buttons with
explicit accessible names and handlers on the buttons. Component tests check
the names and focusability; Chromium checks verify Enter opens Edit and Space
opens Delete.
##########
web-v2/web/src/app/catalogs/rightContent/entitiesContent/SemanticModelDetailsPage.js:
##########
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+'use client'
+
+import { useMemo, useState } from 'react'
+import { Button, Divider, Flex, Popover, Space, Spin, Table, Tabs, Tag,
Tooltip, Typography, message } from 'antd'
+import { useAntdColumnResize } from 'react-antd-column-resize'
+import useResizeObserver from 'use-resize-observer'
+import { useRouter, useSearchParams } from 'next/navigation'
+import Tags from '@/components/CustomTags'
+import GetOwner from '@/components/GetOwner'
+import Icons from '@/components/Icons'
+import PropertiesContent from '@/components/PropertiesContent'
+import { useAppDispatch, useAppSelector } from '@/lib/hooks/useStore'
+import { getSemanticModelDetails } from '@/lib/store/metalakes'
+import { copyToClipboard } from '@/lib/utils'
+import { formatToDateTime, isValidDate } from '@/lib/utils/date'
+import { formatSemanticModelDefinition } from '@/lib/utils/semanticModel'
+import SemanticModelAIContext from './SemanticModelAIContext'
+import SemanticModelExport from './SemanticModelExport'
+import SemanticModelExtensions from './SemanticModelExtensions'
+import CreateSemanticModelDialog from '../CreateSemanticModelDialog'
+
+const { Title, Paragraph } = Typography
+
+const sourceFullName = source => {
+ if (!source) {
+ return '-'
+ }
+
+ return [...(source.namespace || []), source.name].filter(Boolean).join('.')
+}
+
+const renderExpression = expression => {
+ const dialects = expression?.dialects || []
+
+ if (!dialects.length) {
+ return <span>-</span>
+ }
+
+ return (
+ <Space direction='vertical' size={2}>
+ {dialects.map((dialect, index) => (
+ <span key={`${dialect?.dialect}-${index}`}>
+ <Tag>{dialect?.dialect}</Tag>
+ <span className='font-mono text-xs'>{dialect?.expression}</span>
+ </span>
+ ))}
+ </Space>
+ )
+}
+
+const renderColumns = columns => <span className='font-mono text-xs'>{(columns
|| []).join(', ') || '-'}</span>
+
+const hasMetadata = entity => !!entity.aiContext ||
entity.customExtensions?.length > 0
+
+const renderMetadata = (entity, label) => (
+ <>
+ <SemanticModelAIContext context={entity?.aiContext} label={`${label} AI
Context`} />
+ <SemanticModelExtensions extensions={entity?.customExtensions}
label={`${label} Vendor Extensions`} />
+ </>
+)
+
+export default function SemanticModelDetailsPage() {
+ const searchParams = useSearchParams()
+ const router = useRouter()
+ const dispatch = useAppDispatch()
+ const metalake = searchParams.get('metalake')
+ const catalog = searchParams.get('catalog')
+ const schema = searchParams.get('schema')
+ const semanticModelName = searchParams.get('semanticModel')
+ const auth = useAppSelector(state => state.auth)
+ const { anthEnable } = auth
+ const store = useAppSelector(state => state.metalakes)
+ const semanticModel = store.activatedDetails
+ const [tabKey, setTabKey] = useState('Datasets')
+ const [openEdit, setOpenEdit] = useState(false)
+ const { ref, width } = useResizeObserver()
+
+ const definition = semanticModel?.definition
+ const properties = semanticModel?.properties
+ const createdAt = semanticModel?.audit?.createTime
+ const createdAtText = !createdAt || !isValidDate(createdAt) ? '-' :
formatToDateTime(createdAt)
+ const lastModifiedAt = semanticModel?.audit?.lastModifiedTime
+ const lastModifiedText = !lastModifiedAt || !isValidDate(lastModifiedAt) ?
'-' : formatToDateTime(lastModifiedAt)
+ const metadataObjectFullName = `${catalog}.${schema}.${semanticModelName}`
+
+ const datasets = useMemo(
+ () => (definition?.datasets || []).map(dataset => ({ ...dataset, key:
dataset.name })),
+ [definition]
+ )
+
+ const relationships = useMemo(
+ () => (definition?.relationships || []).map(relationship => ({
...relationship, key: relationship.name })),
+ [definition]
+ )
+
+ const metrics = useMemo(
+ () => (definition?.metrics || []).map(metric => ({ ...metric, key:
metric.name })),
+ [definition]
+ )
+
+ const definitionText = useMemo(() =>
formatSemanticModelDefinition(definition), [definition])
+
+ const tagContent = (
+ <div>
+ <Tags readOnly={true} metadataObjectType={'semantic_model'}
metadataObjectFullName={metadataObjectFullName} />
+ </div>
+ )
+
+ const propertyContent = <PropertiesContent properties={properties} />
+
+ const onSaved = async updated => {
+ if (updated.name !== semanticModelName) {
+ const params = new URLSearchParams(searchParams.toString())
+ params.set('semanticModel', updated.name)
+ router.replace(`/catalogs?${params.toString()}`)
+ } else {
+ await dispatch(getSemanticModelDetails({ metalake, catalog, schema,
semanticModel: updated.name, init: true }))
+ }
+ }
+
+ const onCopyDefinition = async () => {
+ try {
+ await copyToClipboard(definitionText)
+ message.success('Definition copied!')
+ } catch (err) {
+ console.error('Failed to copy definition: ', err)
+ message.error('Failed to copy definition')
+ }
+ }
+
+ const datasetColumns = useMemo(
+ () => [
+ {
+ title: 'Dataset Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 200,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ {
+ title: 'Source',
+ dataIndex: 'source',
+ key: 'source',
+ width: 260,
+ ellipsis: true,
+ render: source => <span className='font-mono
text-xs'>{sourceFullName(source)}</span>
+ },
+ {
+ title: 'Primary Key',
+ dataIndex: 'primaryKey',
+ key: 'primaryKey',
+ width: 180,
+ ellipsis: true,
+ render: renderColumns
+ },
+ {
+ title: 'Unique Keys',
+ dataIndex: 'uniqueKeys',
+ key: 'uniqueKeys',
+ width: 220,
+ render: keys =>
+ keys?.length ? (
+ <Space direction='vertical' size={4}>
+ {keys.map((columns, index) => (
+ <Tag key={index}>{renderColumns(columns)}</Tag>
+ ))}
+ </Space>
+ ) : (
+ <span>-</span>
+ )
+ },
+ {
+ title: 'Fields',
+ dataIndex: 'fields',
+ key: 'fields',
+ width: 80,
+ render: fields => <span>{(fields || []).length}</span>
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const fieldColumns = useMemo(
+ () => [
+ {
+ title: 'Field Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 220,
+ render: (name, field) => (
+ <div className='break-words'>
+ <div>{name}</div>
+ {field.label && <Typography.Text
type='secondary'>{field.label}</Typography.Text>}
+ </div>
+ )
+ },
+ {
+ title: 'Data Type',
+ dataIndex: 'datatype',
+ key: 'datatype',
+ width: 140,
+ render: datatype => (datatype ? <Tag>{datatype}</Tag> : <span>-</span>)
+ },
+ {
+ title: 'Time Dimension',
+ dataIndex: 'dimension',
+ key: 'dimension',
+ width: 140,
+ render: dimension => <span>{dimension?.isTime ? 'Yes' : 'No'}</span>
+ },
+ {
+ title: 'Expression',
+ dataIndex: 'expression',
+ key: 'expression',
+ render: renderExpression
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const relationshipColumns = useMemo(
+ () => [
+ {
+ title: 'Relationship Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 220,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ { title: 'From', dataIndex: 'from', key: 'from', width: 160, ellipsis:
true },
+ {
+ title: 'From Columns',
+ dataIndex: 'fromColumns',
+ key: 'fromColumns',
+ width: 200,
+ ellipsis: true,
+ render: renderColumns
+ },
+ { title: 'To', dataIndex: 'to', key: 'to', width: 160, ellipsis: true },
+ {
+ title: 'To Columns',
+ dataIndex: 'toColumns',
+ key: 'toColumns',
+ ellipsis: true,
+ render: renderColumns
+ }
+ ],
+ []
+ )
+
+ const metricColumns = useMemo(
+ () => [
+ {
+ title: 'Metric Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 200,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ {
+ title: 'Data Type',
+ dataIndex: 'datatype',
+ key: 'datatype',
+ width: 140,
+ render: datatype => (datatype ? <Tag>{datatype}</Tag> : <span>-</span>)
+ },
+ {
+ title: 'Expression',
+ dataIndex: 'expression',
+ key: 'expression',
+ render: renderExpression
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const tabOptions = [
+ { label: 'Datasets', key: 'Datasets' },
+ { label: 'Relationships', key: 'Relationships' },
+ { label: 'Metrics', key: 'Metrics' },
+ { label: 'Definition', key: 'Definition' }
+ ]
Review Comment:
Updated the PR description to say "datasets (with expandable fields)". The
nested presentation is intentional: fields remain grouped under their dataset,
alongside that dataset's source and keys.
##########
web-v2/web/src/app/catalogs/rightContent/entitiesContent/SemanticModelDetailsPage.js:
##########
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+'use client'
+
+import { useMemo, useState } from 'react'
+import { Button, Divider, Flex, Popover, Space, Spin, Table, Tabs, Tag,
Tooltip, Typography, message } from 'antd'
+import { useAntdColumnResize } from 'react-antd-column-resize'
+import useResizeObserver from 'use-resize-observer'
+import { useRouter, useSearchParams } from 'next/navigation'
+import Tags from '@/components/CustomTags'
+import GetOwner from '@/components/GetOwner'
+import Icons from '@/components/Icons'
+import PropertiesContent from '@/components/PropertiesContent'
+import { useAppDispatch, useAppSelector } from '@/lib/hooks/useStore'
+import { getSemanticModelDetails } from '@/lib/store/metalakes'
+import { copyToClipboard } from '@/lib/utils'
+import { formatToDateTime, isValidDate } from '@/lib/utils/date'
+import { formatSemanticModelDefinition } from '@/lib/utils/semanticModel'
+import SemanticModelAIContext from './SemanticModelAIContext'
+import SemanticModelExport from './SemanticModelExport'
+import SemanticModelExtensions from './SemanticModelExtensions'
+import CreateSemanticModelDialog from '../CreateSemanticModelDialog'
+
+const { Title, Paragraph } = Typography
+
+const sourceFullName = source => {
+ if (!source) {
+ return '-'
+ }
+
+ return [...(source.namespace || []), source.name].filter(Boolean).join('.')
+}
+
+const renderExpression = expression => {
+ const dialects = expression?.dialects || []
+
+ if (!dialects.length) {
+ return <span>-</span>
+ }
+
+ return (
+ <Space direction='vertical' size={2}>
+ {dialects.map((dialect, index) => (
+ <span key={`${dialect?.dialect}-${index}`}>
+ <Tag>{dialect?.dialect}</Tag>
+ <span className='font-mono text-xs'>{dialect?.expression}</span>
+ </span>
+ ))}
+ </Space>
+ )
+}
+
+const renderColumns = columns => <span className='font-mono text-xs'>{(columns
|| []).join(', ') || '-'}</span>
+
+const hasMetadata = entity => !!entity.aiContext ||
entity.customExtensions?.length > 0
+
+const renderMetadata = (entity, label) => (
+ <>
+ <SemanticModelAIContext context={entity?.aiContext} label={`${label} AI
Context`} />
+ <SemanticModelExtensions extensions={entity?.customExtensions}
label={`${label} Vendor Extensions`} />
+ </>
+)
+
+export default function SemanticModelDetailsPage() {
+ const searchParams = useSearchParams()
+ const router = useRouter()
+ const dispatch = useAppDispatch()
+ const metalake = searchParams.get('metalake')
+ const catalog = searchParams.get('catalog')
+ const schema = searchParams.get('schema')
+ const semanticModelName = searchParams.get('semanticModel')
+ const auth = useAppSelector(state => state.auth)
+ const { anthEnable } = auth
+ const store = useAppSelector(state => state.metalakes)
+ const semanticModel = store.activatedDetails
+ const [tabKey, setTabKey] = useState('Datasets')
+ const [openEdit, setOpenEdit] = useState(false)
+ const { ref, width } = useResizeObserver()
+
+ const definition = semanticModel?.definition
+ const properties = semanticModel?.properties
+ const createdAt = semanticModel?.audit?.createTime
+ const createdAtText = !createdAt || !isValidDate(createdAt) ? '-' :
formatToDateTime(createdAt)
+ const lastModifiedAt = semanticModel?.audit?.lastModifiedTime
+ const lastModifiedText = !lastModifiedAt || !isValidDate(lastModifiedAt) ?
'-' : formatToDateTime(lastModifiedAt)
+ const metadataObjectFullName = `${catalog}.${schema}.${semanticModelName}`
+
+ const datasets = useMemo(
+ () => (definition?.datasets || []).map(dataset => ({ ...dataset, key:
dataset.name })),
+ [definition]
+ )
+
+ const relationships = useMemo(
+ () => (definition?.relationships || []).map(relationship => ({
...relationship, key: relationship.name })),
+ [definition]
+ )
+
+ const metrics = useMemo(
+ () => (definition?.metrics || []).map(metric => ({ ...metric, key:
metric.name })),
+ [definition]
+ )
+
+ const definitionText = useMemo(() =>
formatSemanticModelDefinition(definition), [definition])
+
+ const tagContent = (
+ <div>
+ <Tags readOnly={true} metadataObjectType={'semantic_model'}
metadataObjectFullName={metadataObjectFullName} />
+ </div>
+ )
+
+ const propertyContent = <PropertiesContent properties={properties} />
+
+ const onSaved = async updated => {
+ if (updated.name !== semanticModelName) {
+ const params = new URLSearchParams(searchParams.toString())
+ params.set('semanticModel', updated.name)
+ router.replace(`/catalogs?${params.toString()}`)
+ } else {
+ await dispatch(getSemanticModelDetails({ metalake, catalog, schema,
semanticModel: updated.name, init: true }))
+ }
+ }
+
+ const onCopyDefinition = async () => {
+ try {
+ await copyToClipboard(definitionText)
+ message.success('Definition copied!')
+ } catch (err) {
+ console.error('Failed to copy definition: ', err)
+ message.error('Failed to copy definition')
+ }
+ }
+
+ const datasetColumns = useMemo(
+ () => [
+ {
+ title: 'Dataset Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 200,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ {
+ title: 'Source',
+ dataIndex: 'source',
+ key: 'source',
+ width: 260,
+ ellipsis: true,
+ render: source => <span className='font-mono
text-xs'>{sourceFullName(source)}</span>
+ },
+ {
+ title: 'Primary Key',
+ dataIndex: 'primaryKey',
+ key: 'primaryKey',
+ width: 180,
+ ellipsis: true,
+ render: renderColumns
+ },
+ {
+ title: 'Unique Keys',
+ dataIndex: 'uniqueKeys',
+ key: 'uniqueKeys',
+ width: 220,
+ render: keys =>
+ keys?.length ? (
+ <Space direction='vertical' size={4}>
+ {keys.map((columns, index) => (
+ <Tag key={index}>{renderColumns(columns)}</Tag>
+ ))}
+ </Space>
+ ) : (
+ <span>-</span>
+ )
+ },
+ {
+ title: 'Fields',
+ dataIndex: 'fields',
+ key: 'fields',
+ width: 80,
+ render: fields => <span>{(fields || []).length}</span>
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const fieldColumns = useMemo(
+ () => [
+ {
+ title: 'Field Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 220,
+ render: (name, field) => (
+ <div className='break-words'>
+ <div>{name}</div>
+ {field.label && <Typography.Text
type='secondary'>{field.label}</Typography.Text>}
+ </div>
+ )
+ },
+ {
+ title: 'Data Type',
+ dataIndex: 'datatype',
+ key: 'datatype',
+ width: 140,
+ render: datatype => (datatype ? <Tag>{datatype}</Tag> : <span>-</span>)
+ },
+ {
+ title: 'Time Dimension',
+ dataIndex: 'dimension',
+ key: 'dimension',
+ width: 140,
+ render: dimension => <span>{dimension?.isTime ? 'Yes' : 'No'}</span>
+ },
+ {
+ title: 'Expression',
+ dataIndex: 'expression',
+ key: 'expression',
+ render: renderExpression
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const relationshipColumns = useMemo(
+ () => [
+ {
+ title: 'Relationship Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 220,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ { title: 'From', dataIndex: 'from', key: 'from', width: 160, ellipsis:
true },
+ {
+ title: 'From Columns',
+ dataIndex: 'fromColumns',
+ key: 'fromColumns',
+ width: 200,
+ ellipsis: true,
+ render: renderColumns
+ },
+ { title: 'To', dataIndex: 'to', key: 'to', width: 160, ellipsis: true },
+ {
+ title: 'To Columns',
+ dataIndex: 'toColumns',
+ key: 'toColumns',
+ ellipsis: true,
+ render: renderColumns
+ }
+ ],
+ []
+ )
+
+ const metricColumns = useMemo(
+ () => [
+ {
+ title: 'Metric Name',
+ dataIndex: 'name',
+ key: 'name',
+ width: 200,
+ ellipsis: true,
+ sorter: (a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
+ },
+ {
+ title: 'Data Type',
+ dataIndex: 'datatype',
+ key: 'datatype',
+ width: 140,
+ render: datatype => (datatype ? <Tag>{datatype}</Tag> : <span>-</span>)
+ },
+ {
+ title: 'Expression',
+ dataIndex: 'expression',
+ key: 'expression',
+ render: renderExpression
+ },
+ {
+ title: 'Description',
+ dataIndex: 'description',
+ key: 'description',
+ ellipsis: true,
+ render: description => <span>{description || '-'}</span>
+ }
+ ],
+ []
+ )
+
+ const tabOptions = [
+ { label: 'Datasets', key: 'Datasets' },
+ { label: 'Relationships', key: 'Relationships' },
+ { label: 'Metrics', key: 'Metrics' },
+ { label: 'Definition', key: 'Definition' }
+ ]
+
+ const {
+ resizableColumns: datasetResizableColumns,
+ components: datasetComponents,
+ tableWidth: datasetTableWidth
+ } = useAntdColumnResize(() => {
+ return { columns: datasetColumns, minWidth: 100 }
+ }, [datasetColumns])
+
+ const {
+ resizableColumns: relationshipResizableColumns,
+ components: relationshipComponents,
+ tableWidth: relationshipTableWidth
+ } = useAntdColumnResize(() => {
+ return { columns: relationshipColumns, minWidth: 100 }
+ }, [relationshipColumns])
+
+ const {
+ resizableColumns: metricResizableColumns,
+ components: metricComponents,
+ tableWidth: metricTableWidth
+ } = useAntdColumnResize(() => {
+ return { columns: metricColumns, minWidth: 100 }
+ }, [metricColumns])
+
+ const expandedFieldsRow = dataset => (
+ <div>
+ {renderMetadata(dataset, dataset.name)}
+ <Table
+ data-refer='semantic-model-fields-grid'
+ size='small'
+ rowKey={field => field.name}
+ dataSource={dataset.fields || []}
+ columns={fieldColumns}
+ pagination={false}
+ expandable={{
+ expandedRowRender: field => renderMetadata(field, field.name),
+ rowExpandable: hasMetadata
+ }}
+ />
+ </div>
+ )
+
+ return (
+ <>
+ <Spin spinning={store.activatedDetailsLoading}>
+ <Flex className='mb-2' gap='small' align='flex-start' ref={ref}>
+ <div className='size-8'>
+ <Icons.iconify icon='mdi:graph-outline' className='my-icon-large'
/>
+ </div>
+ <div className='grow-1 relative bottom-1'>
+ <Title level={3} style={{ marginBottom: '0.125rem' }}>
+ <Space>
+ <span
+ title={semanticModelName}
+ className='min-w-10 truncate'
+ style={{ maxWidth: `calc(${width}px - 90px)`, display:
'inherit' }}
+ >
+ {decodeURIComponent(semanticModelName || '')}
+ </span>
+ <Tooltip title='Edit'>
+ <Button
+ type='text'
+ size='small'
+ aria-label='Edit Semantic Model'
+ icon={<Icons.Pencil className='size-4' />}
+ disabled={store.activatedDetailsLoading || !definition}
+ onClick={() => setOpenEdit(true)}
+ />
+ </Tooltip>
+ </Space>
+ </Title>
+ <Paragraph
+ type='secondary'
+ className='truncate'
+ title={semanticModel?.comment}
+ style={{ marginBottom: 0, maxWidth: `calc(${width}px - 56px)` }}
+ >
+ {semanticModel?.comment}
+ </Paragraph>
+ </div>
+ </Flex>
+ <Space split={<Divider type='vertical' />} wrap={true}
className='mb-2'>
+ {anthEnable && (
+ <Space size={4}>
+ <Tooltip title='Owned' placement='top'>
+ <Icons.User className='size-4' color='grey' />
+ </Tooltip>
+ <GetOwner
+ metalake={metalake}
+ metadataObjectType={'semantic_model'}
+ metadataObjectFullName={metadataObjectFullName}
+ />
+ </Space>
+ )}
+ {semanticModel?.audit?.creator && (
+ <Space size={4}>
+ <Tooltip title='Creator' placement='top'>
+ <Icons.UserPen className='size-4' color='grey' />
+ </Tooltip>
+ <span>{semanticModel.audit.creator}</span>
+ </Space>
+ )}
+ <Space size={4}>
+ <Tooltip title='Created' placement='top'>
+ <span className='inline-flex'>
+ <Icons.iconify icon='mdi:clock-outline' className='size-4'
props={{ color: 'grey' }} />
+ </span>
+ </Tooltip>
+ <span>{createdAtText}</span>
+ </Space>
+ <Space size={4}>
+ <Tooltip title='Tags' placement='top'>
+ <Icons.Tags className='size-4' color='grey' />
+ </Tooltip>
+ {store.currentEntityTags && store.currentEntityTags?.length > 0 ? (
+ <Popover placement='bottom' title={<span>Tags</span>}
content={tagContent}>
+ <a
className='text-defaultPrimary'>{store.currentEntityTags?.length}</a>
+ </Popover>
+ ) : (
+ <a className='text-defaultPrimary'>0</a>
+ )}
+ </Space>
+ <Space size={4}>
+ <Tooltip title='Properties' placement='top'>
+ <Icons.TableProperties className='size-4' color='grey' />
+ </Tooltip>
+ {properties && Object.keys(properties).length > 0 ? (
+ <Popover placement='bottom' title={<span>Properties</span>}
content={propertyContent}>
+ <a
className='text-defaultPrimary'>{Object.keys(properties).length}</a>
+ </Popover>
+ ) : (
+ <a className='text-defaultPrimary'>0</a>
+ )}
+ </Space>
+ {semanticModel?.audit?.lastModifier && (
+ <Space size={4} data-refer='semantic-model-last-modifier'>
+ <Tooltip title='Last modified by'>
+ <Icons.UserPen className='size-4' color='grey' />
+ </Tooltip>
+ <span>{semanticModel.audit.lastModifier}</span>
+ </Space>
+ )}
+ {lastModifiedAt && (
+ <Space size={4} data-refer='semantic-model-last-modified-time'>
+ <Tooltip title='Last modified'>
+ <Icons.History className='size-4' color='grey' />
+ </Tooltip>
+ <span>{lastModifiedText}</span>
+ </Space>
+ )}
+ </Space>
+ </Spin>
+ <SemanticModelExport
+ key={metadataObjectFullName}
+ metalake={metalake}
+ catalog={catalog}
+ schema={schema}
+ semanticModel={semanticModelName}
+ disabled={store.activatedDetailsLoading || !definition}
+ />
+ {renderMetadata(definition, 'Model')}
+ <Tabs data-refer='details-tabs' activeKey={tabKey} onChange={setTabKey}
items={tabOptions} />
+ <Spin spinning={store.activatedDetailsLoading}>
+ {tabKey === 'Datasets' && (
+ <Table
+ data-refer='semantic-model-datasets-grid'
+ size='small'
+ style={{ maxHeight: 'calc(100vh - 30rem)' }}
+ scroll={{ x: datasetTableWidth, y: 'calc(100vh - 37rem)' }}
+ dataSource={datasets}
+ columns={datasetResizableColumns}
+ components={datasetComponents}
+ expandable={{
+ expandedRowRender: expandedFieldsRow,
+ rowExpandable: dataset => (dataset.fields || []).length > 0 ||
hasMetadata(dataset)
+ }}
+ pagination={{ position: ['bottomCenter'], showSizeChanger: true }}
+ />
+ )}
+ {tabKey === 'Relationships' && (
+ <Table
+ data-refer='semantic-model-relationships-grid'
+ size='small'
+ style={{ maxHeight: 'calc(100vh - 30rem)' }}
+ scroll={{ x: relationshipTableWidth, y: 'calc(100vh - 37rem)' }}
+ dataSource={relationships}
+ columns={relationshipResizableColumns}
+ components={relationshipComponents}
+ expandable={{
+ expandedRowRender: relationship => renderMetadata(relationship,
relationship.name),
+ rowExpandable: hasMetadata
+ }}
+ pagination={{ position: ['bottomCenter'], showSizeChanger: true }}
+ />
+ )}
+ {tabKey === 'Metrics' && (
+ <Table
+ data-refer='semantic-model-metrics-grid'
+ size='small'
+ style={{ maxHeight: 'calc(100vh - 30rem)' }}
+ scroll={{ x: metricTableWidth, y: 'calc(100vh - 37rem)' }}
+ dataSource={metrics}
+ columns={metricResizableColumns}
+ components={metricComponents}
+ expandable={{
+ expandedRowRender: metric => renderMetadata(metric, metric.name),
+ rowExpandable: hasMetadata
+ }}
+ pagination={{ position: ['bottomCenter'], showSizeChanger: true }}
+ />
+ )}
+ {tabKey === 'Definition' &&
+ (definitionText ? (
+ <div className='relative rounded border border-borderColor p-3'>
+ <Tooltip title='Copy definition' placement='top'>
+ <button
+ type='button'
+ className='absolute right-3 top-3 inline-flex cursor-pointer
items-center rounded border border-borderColor bg-transparent p-1
text-textSecondary transition-colors hover:text-defaultPrimary'
+ onClick={onCopyDefinition}
+ >
Review Comment:
Fixed in 2461081a2. Added `aria-label="Copy definition"` and a component
regression test. The button is also discoverable by that name in the browser
check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
