jerryshao commented on code in PR #13724:
URL: https://github.com/apache/gravitino/pull/13724#discussion_r4246858400
##########
LICENSE.bin:
##########
@@ -406,6 +408,9 @@
IPAddress
Aliyun SDK OSS
QLExpress
+ Fabric8 Kubernetes Client
Review Comment:
I checked each new dependency, and I do not think `NOTICE.bin` needs a
change: none of them ships a NOTICE that is not already there.
- **Fabric8 Kubernetes Client / Model / zjsonpatch 7.2.0**: no NOTICE in the
jars, and none in the upstream repository at tag `v7.2.0` (only `license.txt`,
Apache 2.0).
- **SnakeYAML Engine 2.9**: no NOTICE in the jar, and none upstream at tag
`snakeyaml-engine-2.9` (only `LICENSE.txt`, Apache 2.0).
- **Jackson Dataformat YAML 2.18.3**: its `META-INF/NOTICE` is the standard
"Jackson JSON processor" notice, which `NOTICE.bin` already carries, together
with the FastDoubleParser and Schubfach notices of jackson-core 2.18.3.
As a cross-check, the NOTICE that the build generates into the shaded jar
from the bundled dependencies (`generateBundledLegalFiles`) only collects the
Jackson notices, nothing from fabric8 or SnakeYAML.
So `LICENSE.bin` lists them as bundled Apache 2.0 components, and there is
no upstream notice text to propagate. If the convention here is to name every
bundled component in `NOTICE.bin` regardless, I can add them.
_🤖 Replied by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
