roryqi commented on code in PR #13766: URL: https://github.com/apache/gravitino/pull/13766#discussion_r4246434993
########## api/src/main/java/org/apache/gravitino/policy/IcebergRewriteManifestsContent.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableSet; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.Set; +import org.apache.gravitino.MetadataObject; + +/** + * Placeholder built-in policy content for Iceberg manifest rewrite. + * + * <p>Configurable thresholds will be added when the rewrite-manifests policy lands; this class + * registers the built-in type for TMS task mapping. + */ +public class IcebergRewriteManifestsContent implements PolicyContent { Review Comment: Both this type and `IcebergSnapshotExpirationContent` are registered as public REST-creatable built-in policies even though their content is explicitly placeholder-only and their trigger is always false. This lets users create valid policies that can never take effect. Could we expose these subtypes only when their content semantics and runtime consumers are implemented? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
