lasdf1234 commented on code in PR #13727:
URL: https://github.com/apache/gravitino/pull/13727#discussion_r4230112463
##########
api/src/main/java/org/apache/gravitino/policy/IcebergDataCompactionContent.java:
##########
@@ -122,6 +151,11 @@ private IcebergDataCompactionContent() {
this.deleteFileNumberWeight =
deleteFileNumberWeight == null ? DEFAULT_DELETE_FILE_NUMBER_WEIGHT :
deleteFileNumberWeight;
this.maxPartitionNum = maxPartitionNum == null ? DEFAULT_MAX_PARTITION_NUM
: maxPartitionNum;
+ this.rewriteStrategy =
+ rewriteStrategy == null
+ ? DEFAULT_REWRITE_STRATEGY
+ : rewriteStrategy.trim().toLowerCase(Locale.ROOT);
+ this.sortOrder = sortOrder == null ? DEFAULT_SORT_ORDER : sortOrder.trim();
Review Comment:
No. when rewriteStrategy is sort, validate() requires a non-blank sortOrder
and rejects the empty case. Empty sortOrder is only allowed for binpack. Added
a short comment on the field to clarify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
