FANNG1 commented on PR #13681: URL: https://github.com/apache/gravitino/pull/13681#issuecomment-6051674012
Verified the fix works (checked out the branch, added `ExistOk` assertions to `LanceRESTServiceIT` — 15/15 pass, so `CreateNamespace` is fixed too). Two small suggestions: 1. `docs/lance-rest-service.md:91` still says mode values are only "parsed case-insensitively" and lists every value in snake_case — worth adding that PascalCase (`ExistOk`) is accepted too. 2. `testCreateTableModeAcceptsPascalCase` duplicates `testCreateTableModeNormalizesCase` line for line, only the mode string differs. Could be one test calling `createTable` twice with `Mockito.times(2)` + `getAllValues()`, or a `@ParameterizedTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
