yuqi1129 commented on PR #13666:
URL: https://github.com/apache/gravitino/pull/13666#issuecomment-6036684977
> @yuqi1129 The production change isn't needed here — the fix is already on
`main`. `@Param("roleId")` was added to
`RoleMetaMapper.softDeleteRoleMetaByRoleId` in #10664 (commit `a7914c9ae`), and
#12746 later kept it while adding `@Param("currentVersion")` for OCC. So
#10270's code fix is already in place; this PR only adds the regression guard
the issue itself suggested, so the binding can't silently regress.
>
> There is also existing runtime coverage:
`TestAuthMappers#testRoleDeleteUsesCurrentVersion` calls the mapper through
MyBatis, so a missing `@Param` would already fail there. The reflection test
just makes the contract explicit. Happy to drop it if you'd prefer to rely on
that existing coverage.
I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
