Copilot commented on code in PR #13679:
URL: https://github.com/apache/gravitino/pull/13679#discussion_r4198212660
##########
core/src/main/java/org/apache/gravitino/job/local/LocalJobExecutorConfigs.java:
##########
@@ -36,6 +36,9 @@ private LocalJobExecutorConfigs() {
public static final String JOB_STATUS_KEEP_TIME_MS = "jobStatusKeepTimeInMs";
public static final long DEFAULT_JOB_STATUS_KEEP_TIME_MS = 60 * 60 * 1000;
// 1 hour
+ public static final String CANCEL_FORCE_KILL_DELAY_MS =
"cancelForceKillDelayInMs";
+ public static final long DEFAULT_CANCEL_FORCE_KILL_DELAY_MS = 30 * 1000L; //
30 seconds
Review Comment:
These newly exposed public configuration constants need Javadoc. The
repository guidelines require Javadoc on all new public fields, so documenting
both the key and its default avoids a checkstyle failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
