LuciferYang commented on PR #13444: URL: https://github.com/apache/gravitino/pull/13444#issuecomment-5957056956
Closing this one. `TablePO.equals` and `hashCode` have no production consumer, so the missing payload columns cannot produce a wrong lookup or a lost update today. The update path goes through raw SQL (`TablePOStorageOps.updatePO` to `mapper.updateTableMeta`) with no equality short-circuit, `TablePO` is never a collection element, map key, or dedup target anywhere in the tree, and the optimistic-version check in `TableMetaService` compares individual getters rather than the whole PO. One note if we revisit the value semantics later: the test should enumerate fields by reflection the way `testCopyBuilderCarriesEveryField` does, instead of hardcoding the seven column names. As written it would miss a newly added column, which is the case it is meant to guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
