Copilot commented on code in PR #13458: URL: https://github.com/apache/gravitino/pull/13458#discussion_r4163104654
########## core/src/main/java/org/apache/gravitino/listener/api/event/semantic/SemanticModelEvent.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.semantic; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.listener.api.event.Event; +import org.apache.gravitino.listener.api.event.OperationStatus; + +/** Base class for successful Semantic Model operation events. */ +@DeveloperApi +public abstract class SemanticModelEvent extends Event { + + protected SemanticModelEvent(String user, NameIdentifier identifier) { Review Comment: This new protected constructor is part of the subclass-facing API but has no Javadoc. Add constructor documentation, including both parameters, so the public developer API satisfies the project's Javadoc checks. ########## core/src/main/java/org/apache/gravitino/listener/api/event/semantic/SemanticModelFailureEvent.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.semantic; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.listener.api.event.FailureEvent; + +/** Base class for Semantic Model operation failure events. */ +@DeveloperApi +public abstract class SemanticModelFailureEvent extends FailureEvent { + + protected SemanticModelFailureEvent(String user, NameIdentifier identifier, Exception exception) { Review Comment: This new protected constructor is part of the subclass-facing API but has no Javadoc. Add constructor documentation, including all parameters, so the public developer API satisfies the project's Javadoc checks. ########## core/src/main/java/org/apache/gravitino/listener/api/event/semantic/SemanticModelPreEvent.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.semantic; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.listener.api.event.PreEvent; + +/** Base class for Semantic Model operation pre-events. */ +@DeveloperApi +public abstract class SemanticModelPreEvent extends PreEvent { + + protected SemanticModelPreEvent(String user, NameIdentifier identifier) { Review Comment: This new protected constructor is part of the subclass-facing API but has no Javadoc. Add constructor documentation, including both parameters, so the public developer API satisfies the project's Javadoc checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
