dennismdejong opened a new pull request, #13665:
URL: https://github.com/apache/gravitino/pull/13665

   ### What changes were proposed in this pull request?
   
   Add the regression test proposed in #10273
   (`testDropPartitionStatisticsWithSingleQuotePartitionName`). It writes 
statistics for a
   partition name containing a single quote (`part'ition0`) and asserts that
   `dropStatistics` no longer throws when building the Lance 
`dataset.delete(...)` filter.
   
   The underlying fix (escaping single quotes in SQL-style literals via
   `escapeSqlLiteral`) was already merged in #10324 for #10165, but that PR did 
not
   include this exact test and did not close #10273.
   
   ### Why are the changes needed?
   
   Fix #10273. Verify that quoted partition/statistic names do not produce 
invalid
   delete predicates, which is reachable from the production REST flow for
   drop-partition-statistics requests when Lance partition stats storage is 
enabled.
   
   ### Does this PR introduce any user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   - `./gradlew :core:test --tests 
"org.apache.gravitino.stats.storage.TestLancePartitionStatisticStorage"` (BUILD 
SUCCESSFUL)
   - `./gradlew :core:spotlessCheck` (passes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to