yuqi1129 commented on PR #13588: URL: https://github.com/apache/gravitino/pull/13588#issuecomment-5889476724
@jerryshao Thanks for the review. Addressed in 77cb27aa6: 1. **NoSuchTableException after CREATE** — The repair block now catches `SQLException | NoSuchTableException` and reports the same "created, may be missing its Gravitino identifier, drop before retrying" error, with the original exception as the cause. `testMissingTableIsNotTreatedAsEmptyComment` now asserts this. The load path is unchanged. 2. **CatalogDoris2xIT inheritance** — Now a standalone `BaseIT` suite tagged `doris-multi-version`, like `CatalogDoris3xIT`/`4xIT`. It runs only the 2 comment cases. The `CatalogDorisIT` change is reverted. 3. **Unconditional verification** — Kept on purpose. Gating on the version would cost a comparable `FRONTENDS()` query on a separate connection for each CREATE. Comparing the stored comment also covers other versions or planner settings that drop it. ALTER is only issued, and only needs privilege, when the comment actually differs. I added a code comment and a doc sentence explaining this. 4. **Duplicated create body** — The override now calls `super.create(...)` and repairs on its own connection. I also added a unit test for a NULL `TABLE_COMMENT`. On the image: the 2.1.0 all-in-one image uses the same `fe/`/`be/` layout, and `CatalogDoris2xIT` passes against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
