yuqi1129 opened a new pull request, #13589:
URL: https://github.com/apache/gravitino/pull/13589

   ### What changes were proposed in this pull request?
   
   Backport #13588 to `branch-1.3`. After creating a Doris table, compare the 
stored comment with the submitted comment and restore it with `ALTER TABLE ... 
MODIFY COMMENT` when they differ. Preserve the Gravitino ID suffix and SQL 
escaping, and include the unit tests, Doris 2.1.0 integration coverage, and 
documentation.
   
   ### Why are the changes needed?
   
   Doris 2.1.0 with Nereids enabled can replace a supplied CREATE TABLE comment 
with `OLAP`. The existing read-time fallback cannot recover a comment that was 
lost during creation. This brings the fix to the 1.3 release branch.
   
   Related to #13346; follow-up to #13347. Main PR: #13588.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Table comments now survive creation on affected Doris servers without 
changing planner settings or adding catalog properties. Repair requires ALTER 
permission. If metadata lookup or repair fails after CREATE succeeds, the error 
is reported and the created table may remain.
   
   ### How was this patch tested?
   
   - All 55 Doris module unit tests passed on `branch-1.3`, including 
conditional repair and failure handling.
   - All 3 selected Doris 2.1.0 integration tests passed with Nereids enabled, 
covering ordinary comments, special characters, and Gravitino ID preservation.
   - `./gradlew spotlessApply` and `git show --check` passed.
   
   Run the unit suite with `SKIP_DOCKER_TESTS=true ./gradlew 
:catalogs:catalog-jdbc-doris:test -PskipITs -PskipDockerTests=true`. Run the 
regression coverage with `SKIP_DOCKER_TESTS=false ./gradlew 
:catalogs:catalog-jdbc-doris:test --tests 
'*CatalogDoris2xIT.testTableCommentWithNereids' --tests 
'*CatalogDoris2xIT.testTableCommentRoundTrip' -PskipDockerTests=false 
-PdorisMultiVersionTest`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to