bharos commented on code in PR #13574:
URL: https://github.com/apache/gravitino/pull/13574#discussion_r4127142124
##########
core/src/main/java/org/apache/gravitino/cache/NoOpsCache.java:
##########
@@ -65,14 +64,14 @@ public long size() {
@Override
public <E extends Exception> void withCacheLock(EntityCacheKey key,
ThrowingRunnable<E> action)
throws E {
- opLock.withLockAndThrow(key, action);
+ action.run();
}
/** {@inheritDoc} */
Review Comment:
nit: Maybe specify this ? Because method name portrays that it takes a lock
but now we don't
/** {@inheritDoc} Runs the action directly. This cache holds no state to
lock. */
Same for above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
